Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

donate-cpu-server.py: greatly simplified and optimized stale report and added days query parameter to it #6367

Merged
merged 5 commits into from
May 2, 2024

Conversation

firewave
Copy link
Collaborator

No description provided.

@firewave
Copy link
Collaborator Author

firewave commented Apr 30, 2024

This should greatly improve the runtime of the stale report as it did always read the whole output although it only required to read the first line. It is also configurable now. This will help to identify packages which have the write data discarded because of the exceeded maximum size. We still need a similar report for the information data.

The other changes might not make much a difference although I expect comparing a filename instead of querying the filesystem should be noticeable. Still need to do tests on the actual server.

@firewave firewave changed the title donate-cpu-server.py: optimized and cleaned up the generation of several reports donate-cpu-server.py: optimized and cleaned up the generation of several reports / added days query parameter for stale report Apr 30, 2024
@firewave firewave force-pushed the donate-date branch 5 times, most recently from 8874cc6 to 5dc4e8b Compare April 30, 2024 16:02
@firewave
Copy link
Collaborator Author

stale report on the actual server
22s ~ 38s - before
2s ~ 9s - after

@firewave
Copy link
Collaborator Author

I will split the general improvements into a separate PR as I am not sure they are actually beneficial...

@firewave firewave changed the title donate-cpu-server.py: optimized and cleaned up the generation of several reports / added days query parameter for stale report donate-cpu-server.py: greatly simplified and optimized stale report and added days query parameter to it May 1, 2024
@firewave firewave marked this pull request as ready for review May 1, 2024 09:02
@chrchr-github chrchr-github merged commit 265a505 into danmar:main May 2, 2024
64 checks passed
@firewave firewave deleted the donate-date branch May 2, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants