Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #12667 syntaxError on C23 [[noreturn]] #6351

Merged
merged 6 commits into from
Apr 27, 2024

Conversation

chrchr-github
Copy link
Collaborator

No description provided.

lib/standards.h Outdated
@@ -37,7 +37,7 @@ struct Standards {
enum Language { None, C, CPP };

/** C code standard */
enum cstd_t { C89, C99, C11, CLatest = C11 } c = CLatest;
enum cstd_t { C89, C99, C11, /*, C17*/ C23, CLatest = C23 } c = CLatest;
Copy link
Collaborator

@firewave firewave Apr 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also enable the GUI part and feel free to fully add C17. I somehow forgot about that - it is supported upstream in simplecpp.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out there is no disabled GUI code. So I will take care of both things in a separate PR instead. Sorry about the noise.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by GUI part? I missed the getOnly() function, will add.
C17 doesn't seem to change much, so we'll probably not need an enum value for it: https://en.cppreference.com/w/c/17

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just disregard the comment about the GUI.

The reason it did not add any new language features is most likely the reason I omitted it. But we still need to add it since it changes the standard define string.

@orbitcowboy orbitcowboy merged commit 96f2527 into danmar:main Apr 27, 2024
64 checks passed
@chrchr-github chrchr-github deleted the chr_Fix12667 branch April 27, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants