-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #12667 syntaxError on C23 [[noreturn]] #6351
Conversation
lib/standards.h
Outdated
@@ -37,7 +37,7 @@ struct Standards { | |||
enum Language { None, C, CPP }; | |||
|
|||
/** C code standard */ | |||
enum cstd_t { C89, C99, C11, CLatest = C11 } c = CLatest; | |||
enum cstd_t { C89, C99, C11, /*, C17*/ C23, CLatest = C23 } c = CLatest; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also enable the GUI part and feel free to fully add C17. I somehow forgot about that - it is supported upstream in simplecpp.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turns out there is no disabled GUI code. So I will take care of both things in a separate PR instead. Sorry about the noise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean by GUI part? I missed the getOnly()
function, will add.
C17 doesn't seem to change much, so we'll probably not need an enum value for it: https://en.cppreference.com/w/c/17
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just disregard the comment about the GUI.
The reason it did not add any new language features is most likely the reason I omitted it. But we still need to add it since it changes the standard define string.
No description provided.