Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 12461: False positive: uninitialized buffer, address of and function call with nested array #6350

Merged
merged 2 commits into from
Apr 26, 2024
Merged

Fix 12461: False positive: uninitialized buffer, address of and function call with nested array #6350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd3d704
Fix 12461: False positive: uninitialized buffer, address of and funct…
pfultz2 Apr 26, 2024
42e258f
Format
pfultz2 Apr 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions lib/astutils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -632,6 +632,13 @@ static std::vector<const Token*> getParentMembers(const Token* tok)
return result;
}

static const Token* getParentLifetimeObject(const Token* tok)
{
while (Token::simpleMatch(tok, "["))
tok = tok->astOperand1();
return tok;
}

const Token* getParentLifetime(const Token* tok, const Library& library)
{
std::vector<const Token*> members = getParentMembers(tok);
Expand All @@ -650,9 +657,7 @@ const Token* getParentLifetime(const Token* tok, const Library& library)
return tok;
// If any of the submembers are borrowed types then stop
if (std::any_of(it.base() - 1, members.cend() - 1, [&](const Token* tok2) {
const Token* obj = tok2;
if (Token::simpleMatch(obj, "["))
obj = tok2->astOperand1();
const Token* obj = getParentLifetimeObject(tok2);
const Variable* var = obj->variable();
// Check for arrays first since astIsPointer will return true, but an array is not a borrowed type
if (var && var->isArray())
Expand All @@ -679,9 +684,9 @@ const Token* getParentLifetime(const Token* tok, const Library& library)
return var && var->isReference();
}))
return nullptr;
const Token* result = *it;
if (Token::simpleMatch(result, "[") && result->astOperand1())
return getParentLifetime(result->astOperand1());
const Token* result = getParentLifetimeObject(*it);
if (result != *it)
return getParentLifetime(result);
return result;
}

Expand Down
13 changes: 13 additions & 0 deletions test/testuninitvar.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7503,6 +7503,19 @@ class TestUninitVar : public TestFixture {
"}\n");
ASSERT_EQUALS("[test.cpp:8]: (error) Uninitialized variable: arr\n", errout_str());

valueFlowUninit("struct S {\n"
" void *out;\n"
"};\n"
"void bar(S* s);\n"
"void foo() {\n"
" S s[1][1];\n"
" char arr[5];\n"
" s[0][0].out = &arr;\n"
" bar(s[0]);\n"
" int len = strlen(arr);\n"
"}\n");
ASSERT_EQUALS("", errout_str());

valueFlowUninit("struct S1 { int x; };\n" // #12401
"struct S2 { struct S1 s1; };\n"
"struct S2 f() {\n"
Expand Down
Loading