Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed some cmakelint warnings #6318

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Fixed some cmakelint warnings #6318

merged 2 commits into from
Apr 23, 2024

Conversation

orbitcowboy
Copy link
Collaborator

@orbitcowboy orbitcowboy commented Apr 21, 2024

This fixes

$ cmakelint CMakeLists.txt 
CMakeLists.txt:2: Extra spaces between 'if' and its () [whitespace/extra]
CMakeLists.txt:10: Extra spaces between 'set' and its () [whitespace/extra]
$ cmakelint cmake/*cmake
clang_tidy.cmake:3: Extra spaces between 'if' and its () [whitespace/extra]
clang_tidy.cmake:5: Extra spaces between 'if' and its () [whitespace/extra]
clang_tidy.cmake:17: Extra spaces between 'if' and its () [whitespace/extra]
clang_tidy.cmake:20: Extra spaces between 'if' and its () [whitespace/extra]
clang_tidy.cmake:30: Extra spaces between 'if' and its () [whitespace/extra]
clang_tidy.cmake:32: Extra spaces between 'if' and its () [whitespace/extra]
compilerCheck.cmake:1: Extra spaces between 'if' and its () [whitespace/extra]
compilerCheck.cmake:2: Extra spaces between 'if' and its () [whitespace/extra]
compilerCheck.cmake:4: Extra spaces between 'endif' and its () [whitespace/extra]
compilerCheck.cmake:6: Extra spaces between 'if' and its () [whitespace/extra]
compilerCheck.cmake:8: Extra spaces between 'endif' and its () [whitespace/extra]
compilerCheck.cmake:10: Extra spaces between 'if' and its () [whitespace/extra]
compilerCheck.cmake:12: Extra spaces between 'endif' and its () [whitespace/extra]
compilerDefinitions.cmake:1: Extra spaces between 'if' and its () [whitespace/extra]
compilerDefinitions.cmake:16: Extra spaces between 'if' and its () [whitespace/extra]
compilerDefinitions.cmake:17: Extra spaces between 'if' and its () [whitespace/extra]
compilerDefinitions.cmake:18: Extra spaces between 'if' and its () [whitespace/extra]
compilerDefinitions.cmake:19: Extra spaces between 'if' and its () [whitespace/extra]
compilerDefinitions.cmake:32: Extra spaces between 'if' and its () [whitespace/extra]
compilerDefinitions.cmake:36: Extra spaces between 'if' and its () [whitespace/extra]
compilerDefinitions.cmake:40: Extra spaces between 'if' and its () [whitespace/extra]
compilerDefinitions.cmake:44: Extra spaces between 'if' and its () [whitespace/extra]
compilerDefinitions.cmake:48: Extra spaces between 'if' and its () [whitespace/extra]
compilerDefinitions.cmake:52: Extra spaces between 'if' and its () [whitespace/extra]
compilerDefinitions.cmake:56: Extra spaces between 'if' and its () [whitespace/extra]
compilerDefinitions.cmake:60: Extra spaces between 'if' and its () [whitespace/extra]
compileroptions.cmake:6: Extra spaces between 'if' and its () [whitespace/extra]
compileroptions.cmake:10: Line ends in whitespace [whitespace/eol]
compileroptions.cmake:14: Extra spaces between 'if' and its () [whitespace/extra]
compileroptions.cmake:20: Extra spaces between 'if' and its () [whitespace/extra]
compileroptions.cmake:27: Extra spaces between 'if' and its () [whitespace/extra]
compileroptions.cmake:31: Extra spaces between 'if' and its () [whitespace/extra]
compileroptions.cmake:36: Extra spaces between 'if' and its () [whitespace/extra]
compileroptions.cmake:64: Extra spaces between 'if' and its () [whitespace/extra]
compileroptions.cmake:71: Extra spaces between 'elseif' and its () [whitespace/extra]
compileroptions.cmake:72: Extra spaces between 'if' and its () [whitespace/extra]
compileroptions.cmake:74: Extra spaces between 'if' and its () [whitespace/extra]
compileroptions.cmake:77: Extra spaces between 'if' and its () [whitespace/extra]
compileroptions.cmake:86: Extra spaces between 'if' and its () [whitespace/extra]
compileroptions.cmake:136: Extra spaces between 'if' and its () [whitespace/extra]
compileroptions.cmake:142: Extra spaces between 'if' and its () [whitespace/extra]
compileroptions.cmake:216: Extra spaces between 'if' and its () [whitespace/extra]
compileroptions.cmake:222: Extra spaces between 'if' and its () [whitespace/extra]
compileroptions.cmake:223: Tab found; please use spaces [whitespace/tabs]
compileroptions.cmake:226: Extra spaces between 'if' and its () [whitespace/extra]
cxx11.cmake:3: Extra spaces between 'if' and its () [whitespace/extra]
cxx11.cmake:5: Extra spaces between 'set' and its () [whitespace/extra]
cxx11.cmake:6: Extra spaces between 'else' and its () [whitespace/extra]
cxx11.cmake:7: Extra spaces between 'set' and its () [whitespace/extra]
cxx11.cmake:9: Expression repeated inside endmacro; better to use only endmacro() [readability/logic]
dynamic_analyzer_options.cmake:23: Extra spaces between 'if' and its () [whitespace/extra]
dynamic_analyzer_options.cmake:30: Extra spaces between 'if' and its () [whitespace/extra]
findDependencies.cmake:1: Extra spaces between 'if' and its () [whitespace/extra]
findDependencies.cmake:3: Extra spaces between 'if' and its () [whitespace/extra]
findDependencies.cmake:6: Extra spaces between 'if' and its () [whitespace/extra]
findDependencies.cmake:9: Extra spaces between 'if' and its () [whitespace/extra]
findDependencies.cmake:12: Extra spaces between 'if' and its () [whitespace/extra]
findDependencies.cmake:17: Extra spaces between 'if' and its () [whitespace/extra]
findDependencies.cmake:33: Extra spaces between 'if' and its () [whitespace/extra]
findDependencies.cmake:36: Extra spaces between 'if' and its () [whitespace/extra]
findDependencies.cmake:43: Extra spaces between 'if' and its () [whitespace/extra]
findDependencies.cmake:45: Extra spaces between 'if' and its () [whitespace/extra]
findDependencies.cmake:51: Extra spaces between 'if' and its () [whitespace/extra]
findDependencies.cmake:54: Extra spaces between 'if' and its () [whitespace/extra]
findDependencies.cmake:59: Extra spaces between 'if' and its () [whitespace/extra]
findDependencies.cmake:66: Extra spaces between 'if' and its () [whitespace/extra]
findDependencies.cmake:68: Extra spaces between 'if' and its () [whitespace/extra]
findDependencies.cmake:74: Extra spaces between 'if' and its () [whitespace/extra]
findDependencies.cmake:84: Extra spaces between 'if' and its () [whitespace/extra]
options.cmake:5: Weird indentation; use 2 spaces [whitespace/indent]
options.cmake:9: Weird indentation; use 2 spaces [whitespace/indent]
options.cmake:27: Extra spaces between 'if' and its () [whitespace/extra]
options.cmake:30: Extra spaces between 'if' and its () [whitespace/extra]
options.cmake:31: Extra spaces between 'if' and its () [whitespace/extra]
options.cmake:41: Extra spaces between 'if' and its () [whitespace/extra]
options.cmake:57: Extra spaces between 'if' and its () [whitespace/extra]
options.cmake:65: Extra spaces between 'if' and its () [whitespace/extra]
options.cmake:74: Extra spaces between 'if' and its () [whitespace/extra]
options.cmake:83: Extra spaces between 'if' and its () [whitespace/extra]
printInfo.cmake:1: Mismatching spaces inside () after command [whitespace/mismatch]
printInfo.cmake:3: Mismatching spaces inside () after command [whitespace/mismatch]
printInfo.cmake:4: Mismatching spaces inside () after command [whitespace/mismatch]
printInfo.cmake:6: Mismatching spaces inside () after command [whitespace/mismatch]
printInfo.cmake:7: Mismatching spaces inside () after command [whitespace/mismatch]
printInfo.cmake:8: Mismatching spaces inside () after command [whitespace/mismatch]
printInfo.cmake:9: Mismatching spaces inside () after command [whitespace/mismatch]
printInfo.cmake:12: Mismatching spaces inside () after command [whitespace/mismatch]
printInfo.cmake:13: Mismatching spaces inside () after command [whitespace/mismatch]
printInfo.cmake:14: Mismatching spaces inside () after command [whitespace/mismatch]
printInfo.cmake:15: Mismatching spaces inside () after command [whitespace/mismatch]
printInfo.cmake:16: Mismatching spaces inside () after command [whitespace/mismatch]
printInfo.cmake:23: Extra spaces between 'if' and its () [whitespace/extra]
printInfo.cmake:41: Mismatching spaces inside () after command [whitespace/mismatch]
printInfo.cmake:42: Mismatching spaces inside () after command [whitespace/mismatch]
printInfo.cmake:43: Mismatching spaces inside () after command [whitespace/mismatch]
printInfo.cmake:44: Mismatching spaces inside () after command [whitespace/mismatch]
printInfo.cmake:50: Expression repeated inside endif; better to use only endif() [readability/logic]
printInfo.cmake:62: Extra spaces between 'if' and its () [whitespace/extra]
printInfo.cmake:66: Mismatching spaces inside () after command [whitespace/mismatch]
printInfo.cmake:70: Extra spaces between 'if' and its () [whitespace/extra]
printInfo.cmake:78: Extra spaces between 'if' and its () [whitespace/extra]
printInfo.cmake:84: Extra spaces between 'if' and its () [whitespace/extra]
printInfo.cmake:85: Mismatching spaces inside () after command [whitespace/mismatch]
printInfo.cmake:86: Mismatching spaces inside () after command [whitespace/mismatch]
printInfo.cmake:87: Mismatching spaces inside () after command [whitespace/mismatch]
printInfo.cmake:93: Weird indentation; use 2 spaces [whitespace/indent]
printInfo.cmake:94: Weird indentation; use 2 spaces [whitespace/indent]
printInfo.cmake:95: Weird indentation; use 2 spaces [whitespace/indent]
qtCompat.cmake:1: Extra spaces between 'if' and its () [whitespace/extra]

@orbitcowboy orbitcowboy marked this pull request as draft April 21, 2024 11:39
@orbitcowboy orbitcowboy marked this pull request as ready for review April 21, 2024 18:50
@orbitcowboy orbitcowboy merged commit 642cdfd into main Apr 23, 2024
64 checks passed
@orbitcowboy orbitcowboy deleted the cmakelint branch April 23, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant