Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated Qt in CI to 6.7.0 #6290

Merged
merged 2 commits into from
Apr 15, 2024
Merged

updated Qt in CI to 6.7.0 #6290

merged 2 commits into from
Apr 15, 2024

Conversation

firewave
Copy link
Collaborator

No description provided.

@firewave
Copy link
Collaborator Author

firewave commented Apr 14, 2024

The unused function selfcheck failed with:

cmake.output.notest/gui/cppcheck-gui_autogen/EWIEGA46WW/moc_aboutdialog.cpp:41:0: error: #error "qtmochelpers.h not found or too old." [preprocessorErrorDirective]
#error "qtmochelpers.h not found or too old."
^

This required an additional define to be set for it.

The strange thing about this is that it should have been reported for every moc_*.cpp file and not just a single one. And it should also have been reported in the other selfchecks. That might indicate that either not all files are analyzed or that the error somehow interfers with the analysis across files.

@chrchr-github chrchr-github merged commit 040b782 into danmar:main Apr 15, 2024
64 checks passed
@firewave firewave deleted the qt-67 branch April 15, 2024 17:25
@firewave
Copy link
Collaborator Author

The strange thing about this is that it should have been reported for every moc_*.cpp file and not just a single one.

There was only a single warning because all the moc_*.cpp files are compiled at once via mocs_compilation.cpp.

@firewave
Copy link
Collaborator Author

And it should also have been reported in the other selfchecks.

The other selfchecks are still using either Qt5 or the version from the distro so they obviously do not experience the Qt 6.7.0 related error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants