Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

made more mErrorLogger members references #6276

Merged
merged 2 commits into from
Apr 11, 2024
Merged

made more mErrorLogger members references #6276

merged 2 commits into from
Apr 11, 2024

Conversation

firewave
Copy link
Collaborator

No description provided.

danmar
danmar approved these changes Apr 11, 2024
View reviewed changes
Copy link
Owner

@danmar danmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I like converting pointers to references more and more 👍

@firewave
Copy link
Collaborator Author

lgtm. I like converting pointers to references more and more 👍

Yeah, and getting of things being optional for the sake of testing code.

This is probably the last one for a while. The remaining ones require #5323 to land first.

@firewave firewave merged commit 437c284 into danmar:main Apr 11, 2024
64 checks passed
@firewave firewave deleted the ptr-ref-e branch April 11, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danmar danmar danmar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@firewave @danmar