Tokenizer: moved test-only tokenize() to SimpleTokenizer / several cleanups
#6264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test code is quite awkward in places but that just highlights that we need to handle things differently or have more redundant code to get rid of. These changes will help cleaning up the application code further though. |
firewave
force-pushed
the
tok-test-simple
branch
from
7ecc1df
to
2ef324c
Compare
firewave
force-pushed
the
tok-test-simple
branch
2 times, most recently
from
ed342c4
to
7906917
Compare
firewave
force-pushed
the
tok-test-simple
branch
from
7906917
to
d68431b
Compare
danmar
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.