Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #12546 new check: suggest to return const reference from "getter" member function #6256

Merged
merged 23 commits into from
Apr 10, 2024

Conversation

chrchr-github
Copy link
Collaborator

No description provided.

@chrchr-github chrchr-github marked this pull request as ready for review April 8, 2024 20:54
Copy link
Owner

@danmar danmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. I just have a small nit.

lib/checkclass.cpp Outdated Show resolved Hide resolved
@chrchr-github chrchr-github merged commit 4f8f7cc into danmar:main Apr 10, 2024
64 checks passed
@chrchr-github chrchr-github deleted the chr_Fix12546 branch April 10, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants