Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows.cfg: Added support for more obsolete functions #6251

Merged
merged 1 commit into from
Apr 7, 2024

Conversation

orbitcowboy
Copy link
Collaborator

No description provided.

@orbitcowboy
Copy link
Collaborator Author

Codecov seems to have problem, which is unrelated this change:
Error: Codecov: Failed to properly upload: The process '/home/runner/work/_actions/codecov/codecov-action/v3/dist/codecov

@firewave firewave changed the title windows.cfg: Added support for more obsolte functions windows.cfg: Added support for more obsolete functions Apr 7, 2024
@firewave
Copy link
Collaborator

firewave commented Apr 7, 2024

The v4 release notes say that tokenless upload is no longer supported. We are still using v3 but it seems they disabled it unconditionally. That most likely requires interaction from @danmar - should be the same fix which would have fixed the sporadic failures - by install the codecov app for the report. See also https://trac.cppcheck.net/ticket/12112.

@firewave
Copy link
Collaborator

firewave commented Apr 7, 2024

The v3 action appears to use the v4 API:

[2024-04-07T11:12:15.874Z] ['info'] Pinging Codecov: https://codecov.io/upload/v4?package=github-action-3.1.6-uploader-0.7.2&token=*******&branch=windows_cfg_added_more_obsolte_functions&build=8586929612&build_url=https%3A%2F%2Fgithub.com%2Fdanmar%2Fcppcheck%2Factions%2Fruns%2F8586929612%2Fjob%2F23532898031&commit=5f9e79c47e8f116481df6fb981dc67eef975344e&job=Coverage&pr=6251&service=github-actions&slug=danmar%2Fcppcheck&name=danmar%2Fcppcheck&tag=&flags=unittests&parent=
[2024-04-07T11:12:16.167Z] ['error'] There was an error running the uploader: Error uploading to [https://codecov.io:](https://codecov.io/) Error: There was an error fetching the storage URL during POST: 404 - {'detail': ErrorDetail(string='Unable to locate build via Github Actions API. Please upload with the Codecov repository upload token to resolve issue.', code='not_found')}
Error: Codecov: Failed to properly upload: The process '/home/runner/work/_actions/codecov/codecov-action/v3/dist/codecov' failed with exit code 255

I filed codecov/codecov-action#1359 upstream.

@firewave firewave merged commit 3d79910 into main Apr 7, 2024
63 of 64 checks passed
@firewave firewave deleted the windows_cfg_added_more_obsolte_functions branch April 7, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants