testrunner: small TestSimplifyTokens cleanup / fixed valueflow message suppression / improved ignoring of output
#6243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All these (obsolete) bools in the signatures gave me headaches in an upcoming refactoring. |
firewave
commented
Apr 5, 2024
| std::string line; | ||
| while (std::getline(istr2,line)) { | ||
| if (line.find("bailout") == std::string::npos) | ||
| {} // TODO mErrout << line << "\n"; |
There was a problem hiding this comment.
This actually suppressed all possible messages.
There was a problem hiding this comment.
I found more of this which still needs fixing.
firewave
changed the title
TestSimplifyTokens cleanupTestSimplifyTokens cleanup / fixed valueflow message suppression
firewave
force-pushed
the
test-tokens
branch
2 times, most recently
from
ff05346
to
cf750cb
Compare
firewave
changed the title
TestSimplifyTokens cleanup / fixed valueflow message suppressionTestSimplifyTokens cleanup / fixed valueflow message suppression / improved ignoring of output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.