Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enabled and mitigated performance-avoid-endl clang-tidy warnings #6239

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

firewave
Copy link
Collaborator

@firewave firewave commented Apr 5, 2024

This will also help with reducing valueFlowBailoutIncompleteVar warnings in our code base.

@firewave
Copy link
Collaborator Author

firewave commented Apr 5, 2024

There is most likely some explicit flushes to be added to have a good CLI experience. I have not looked into it yet.

@firewave
Copy link
Collaborator Author

firewave commented Apr 5, 2024

It seems the missing flushes somehow expose a bug in the pipe communication in the ProcessExecutor:

reportOut - Checking /tmp/pytest-of-user/pytest-8/test_markup_j0/test_2.cpp ...
handleRead - Checking /tmp/pytest-of-user/pytest-8/test_markup_j0/test_2.cpp ...
reportOut - Checking /tmp/pytest-of-user/pytest-8/test_markup_j0/test_4.cpp ...
handleRead - Checking /tmp/pytest-of-user/pytest-8/test_markup_j0/test_2.cpp ...
handleRead - Checking /tmp/pytest-of-user/pytest-8/test_markup_j0/test_4.cpp ...
reportOut - Checking /tmp/pytest-of-user/pytest-8/test_markup_j0/test_1.qml ...
handleRead - Checking /tmp/pytest-of-user/pytest-8/test_markup_j0/test_2.cpp ...
handleRead - Checking /tmp/pytest-of-user/pytest-8/test_markup_j0/test_4.cpp ...
handleRead - Checking /tmp/pytest-of-user/pytest-8/test_markup_j0/test_1.qml ...
reportOut - Checking /tmp/pytest-of-user/pytest-8/test_markup_j0/test_3.qml ...
handleRead - Checking /tmp/pytest-of-user/pytest-8/test_markup_j0/test_2.cpp ...
handleRead - Checking /tmp/pytest-of-user/pytest-8/test_markup_j0/test_4.cpp ...
handleRead - Checking /tmp/pytest-of-user/pytest-8/test_markup_j0/test_1.qml ...
handleRead - Checking /tmp/pytest-of-user/pytest-8/test_markup_j0/test_3.qml ...

@firewave
Copy link
Collaborator Author

firewave commented Apr 5, 2024

I cannot reproduce it outside of the Python test so it must be related to subprocess.Popen().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant