Cleanup in createSymbolDatabaseIncompleteVars() #6238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrchr-github
commented
Apr 5, 2024
firewave
reviewed
Apr 5, 2024
| @@ -1524,11 +1463,14 @@ void SymbolDatabase::createSymbolDatabaseIncompleteVars() | |||
| tok = tok->link(); | |||
| continue; | |||
| } | |||
| if (Token::Match(tok, "catch|typeid (")) { | |||
| if (tok->isCpp() && (Token::Match(tok, "catch|typeid (") || | |||
| Token::Match(tok, "static_cast|dynamic_cast|const_cast|reinterpret_cast"))) { | |||
There was a problem hiding this comment.
This does not check for the opening (<) unlike the previous condition - is that intentional? Could this be replaced with isCast()?
There was a problem hiding this comment.
There was no explicit handling of C++ casts (and the stuff between <...>) in createSymbolDatabaseIncompleteVars(), so I wonder how that worked.
isCast() is set for (, so that's too late for the target type.
We should also reject a C++ cast keyword not followed by < as a syntax error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.