Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default to --check-level=exhaustive internally / several related cleanups #6225

Merged
merged 5 commits into from
Apr 11, 2024

Conversation

firewave
Copy link
Collaborator

@firewave firewave commented Apr 3, 2024

No description provided.

@@ -851,6 +851,9 @@ class TestSimplifyUsing : public TestFixture {
"}";

ASSERT_EQUALS(exp, tok(code));
ASSERT_EQUALS("[test.cpp:7]: (debug) valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NS1\n"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@firewave firewave force-pushed the exhaustive branch 2 times, most recently from eae9641 to ebca683 Compare April 7, 2024 21:17
@firewave firewave marked this pull request as draft April 8, 2024 10:12
@firewave firewave marked this pull request as ready for review April 8, 2024 10:17
@firewave firewave marked this pull request as draft April 8, 2024 10:28
@firewave firewave force-pushed the exhaustive branch 2 times, most recently from 85ccd86 to 1e5d69e Compare April 11, 2024 08:05
@firewave
Copy link
Collaborator Author

I flaked on some of the test fixes since there were so many messages to handle. We definitely need to clean this up more so the code doesn't produce the warnings and we no longer need to ignore stuff.

@firewave firewave marked this pull request as ready for review April 11, 2024 08:20
@firewave firewave merged commit 524e979 into danmar:main Apr 11, 2024
64 checks passed
@firewave firewave deleted the exhaustive branch April 11, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants