Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iwyu.yml: use Qt 6.7.0 for include-what-you-use #6218

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

firewave
Copy link
Collaborator

@firewave firewave commented Apr 2, 2024

Starting with Qt 6.7.0 we no longer require the Qt mappings because IWYU annotations have been added to the headers upstream (see https://bugreports.qt.io/browse/QTBUG-119505).

@firewave
Copy link
Collaborator Author

firewave commented Apr 2, 2024

jurplel/install-qt-action does not seem to work with OpenSUSE

Error: Error: Unable to locate executable file: apt-get. Please verify either the file path exists or the file can be found within a directory specified by the PATH environment variable. Also check the file mode to verify the file is executable.

I filed jurplel/install-qt-action#232 upstream.

Also somehow installing Qt 6.7.0 doesn't work:

/opt/hostedtoolcache/Python/3.11.8/x64/bin/python3 -m aqt install-qt linux desktop 6.7.0 --outputdir /home/runner/work/cppcheck/Qt --modules qtcharts
INFO    : aqtinstall(aqt) v3.1.12 on Python 3.11.8 [CPython GCC 11.4.0]
ERROR   : The packages ['qt_base', 'qtcharts'] were not found while parsing XML of package information!
==============================Suggested follow-up:==============================
* Please use 'aqt list-qt linux desktop --arch 6.7.0' to show architectures available.
* Please use 'aqt list-qt linux desktop --modules 6.7.0 <arch>' to show modules available.
Error: Error: The process '/opt/hostedtoolcache/Python/3.11.8/x64/bin/python3' failed with exit code 1

I filed jurplel/install-qt-action#231 upstream.

@firewave firewave force-pushed the iwyu-qt6 branch 2 times, most recently from 0b483b6 to 18a1b7c Compare April 2, 2024 11:54
@firewave
Copy link
Collaborator Author

firewave commented Apr 2, 2024

jurplel/install-qt-action does not seem to work with OpenSUSE

This is only about installing the dependencies which we do not even need since we only require the headers.

@firewave
Copy link
Collaborator Author

The 6.7.0 install issue is fixed upstream.

Fedora Rawhide is already on 6.7.0 so we could switch to that to get rid of the Qt mappings but unfortunately they are still at a later include-what-you-use version...

@firewave firewave changed the title iwyu.yml: use Qt6 iwyu.yml: use Qt 6.7.0 for include-what-you-use Apr 14, 2024
@firewave
Copy link
Collaborator Author

ArchLinux has Qt 6.7.0 and IWYU 0.21 but somehow lupdate is broken on it...

@firewave firewave force-pushed the iwyu-qt6 branch 11 times, most recently from e4605cc to 7c82241 Compare April 15, 2024 19:01
@firewave
Copy link
Collaborator Author

@firewave firewave marked this pull request as ready for review April 15, 2024 19:17
@chrchr-github chrchr-github merged commit 82fcffa into danmar:main Apr 15, 2024
64 checks passed
@firewave firewave deleted the iwyu-qt6 branch April 15, 2024 20:44
@firewave
Copy link
Collaborator Author

Somehow it does not pick up the IWYU pragmas from the Qt headers and still suggests the wrong headers. This was definitely working while I tested these changes.

@firewave
Copy link
Collaborator Author

Somehow it does not pick up the IWYU pragmas from the Qt headers and still suggests the wrong headers. This was definitely working while I tested these changes.

There are actually being used there are just lots of shortcomings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants