fixed checks related to unusedFunction check enablement
#6207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This came up while working on #5647. Since the tests which exposed this issue are heavily dependent on those changes I do not have any tests I can add here. It is quite possible the whole issue is latent without the other changes and will never occur. |
|
A potential issue here was previously noted in #5979 (comment). |
firewave
changed the title
unusedFunction check enablement
danmar
approved these changes
Apr 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caused the
unmatchedSuppressionfor an inlineunusedFunctionsuppression not to be reported with-j2when using--executor=thread.