removed original filenames from TokenList and ErrorMessage::FileLocation / added missing ErrorMessage::FileLocation::mFile normalization / some cleanups
#6182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I went a bit overboard with the cleanups. I will pull out the unrelated changes into a separate PR. I also think I miss a testcase of the empty original filename case. |
firewave
force-pushed
the
errorlog
branch
3 times, most recently
from
63c9d92
to
6f8ab85
Compare
|
The original filename is actually different in |
…cation` [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way
ErrorMessage::FileLocationwas created there was no case where the names were differed. That could only happen when those came from theTokenList.The
TokenListone could have only differed whenTokenList::clangSetOrigFiles()was called. That copied the names over. It was only done in the Clang Import but the names were not touched afterwards so they never differed and this was completely unnecessary.Also the way
ErrorMessage::FileLocationwas used in several cases the original name was never set at all.The name was also not normalized in
ErrorMessage::FileLocationwhen set via the constructor.