Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed #12523 - greatly improved errorhandling of --rule-file= #6147

Merged
merged 11 commits into from
Mar 21, 2024

Conversation

firewave
Copy link
Collaborator

No description provided.

@firewave
Copy link
Collaborator Author

I will do further improvements after some refactoring which I will do in a separate PR so the changes are easier to follow.

@firewave
Copy link
Collaborator Author

I have no idea why this fails on ubuntu 23.10 only:

/__w/cppcheck/cppcheck/cli/cmdlineparser.cpp: In member function 'CmdLineParser::Result CmdLineParser::parseFromArgs(int, const char* const*)':
/__w/cppcheck/cppcheck/cli/cmdlineparser.cpp:1090:50: error: 'empty_if_null' was not declared in this scope
 1090 |                                 rule.tokenlist = empty_if_null(subtext);
      |                                                  ^~~~~~~~~~~~~
/__w/cppcheck/cppcheck/cli/cmdlineparser.cpp:1093:48: error: 'empty_if_null' was not declared in this scope
 1093 |                                 rule.pattern = empty_if_null(subtext);
      |                                                ^~~~~~~~~~~~~
/__w/cppcheck/cppcheck/cli/cmdlineparser.cpp:1099:76: error: 'empty_if_null' was not declared in this scope
 1099 |                                         rule.severity = severityFromString(empty_if_null(msgtext));
      |                                                                            ^~~~~~~~~~~~~
/__w/cppcheck/cppcheck/cli/cmdlineparser.cpp:1102:51: error: 'empty_if_null' was not declared in this scope
 1102 |                                         rule.id = empty_if_null(msgtext);
      |                                                   ^~~~~~~~~~~~~
/__w/cppcheck/cppcheck/cli/cmdlineparser.cpp:1105:56: error: 'empty_if_null' was not declared in this scope
 1105 |                                         rule.summary = empty_if_null(msgtext);
      |                                                        ^~~~~~~~~~~~~

@firewave firewave marked this pull request as draft March 21, 2024 09:58
@firewave firewave marked this pull request as ready for review March 21, 2024 16:12
@orbitcowboy orbitcowboy merged commit 91f1a25 into danmar:main Mar 21, 2024
64 checks passed
@firewave firewave deleted the rule-file branch March 21, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants