Fix #12505 (cli: Add option --check-version to pin cppcheck version) #6121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is the actual use case for this? I have never seen something like this and I do not like this at all. |
firewave
requested changes
Mar 13, 2024
|
We should simply return the raw version via something like |
I don't see how that would help. It's the full --version output that is interesting for safety. |
firewave
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I chose to not add it in the help output. But I don't have a strong opinion it can be added there also.
This option was added for the safety certification. It could be very bad if a user runs one version of cppcheck and thinks that he runs another version.