Fix syntaxError with using namespace ::std (f'up to #8454)

[chrchr-github]

Why do %type% and %name% match keywords?

[firewave]

Why do %type% and %name% match keywords?

Because we might have a bug. I vaguely remember something similar (I might be mistaken though). Maybe add some additional unit tests for that.

There's also https://trac.cppcheck.net/ticket/11169 which could be addressed along the way. Looking at the ticket it seems to explain the issue you are seeing...

[chrchr-github]

I bet we also have code that relies on the current behavior...

[firewave]

I bet we also have code that relies on the current behavior...

For sure. Just makes things more interesting. The fun never ends...

But just having TODO testcases would be a start.

[chrchr-github]

Just changing %type% alone causes massive test failures all over the place.
The comments from Token::Match() are also hilarious:

     * - "%name%" any token which is a name, variable or type e.g. "hello" or "int"
     * - "%type%" Anything that can be a variable type, e.g. "int", but not "delete".

[firewave]

TGIF

[danmar]

lgtm

[danmar]

Why do %type% and %name% match keywords?

this is old decisions I don't even remember exactly. but in my head %name% is broad and I think it makes sense it matches keywords.

if we can make %type% more intuitive that is good.. I would not be strongly against that in theory. but well in practice I guess it breaks tons of code so let's be careful.

[firewave]

if we can make %type% more intuitive that is good.. I would not be strongly against that in theory. but well in practice I guess it breaks tons of code so let's be careful.

We could introduce some debug or internal checks to try to get a hold on it.