Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added environment variable TEST_CPPCHECK_INJECT_J to inject -j into the cppcheck invocation of Python tests #6061

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

firewave
Copy link
Collaborator

No description provided.

@firewave firewave force-pushed the test-inject-j branch 2 times, most recently from ee59751 to 3cbd136 Compare March 1, 2024 13:36
…to the cppcheck invocation of Python tests
@firewave
Copy link
Collaborator Author

firewave commented Mar 1, 2024

As per #6043 (comment).

I also cleaned up the unnecessarily duplicated tests, adjusted some parameters (mainly disabling unusedFunction where we do not require it) and added some TODOs for tests I didn't have the time to look into yet.

@firewave
Copy link
Collaborator Author

firewave commented Mar 1, 2024

test_markup_j is suddenly failing on some targets in the -j2 run. That is rather strange as it is always called with -j2...

@firewave firewave marked this pull request as ready for review March 1, 2024 14:28
@firewave
Copy link
Collaborator Author

firewave commented Mar 1, 2024

GitHub is currently not behaving well. So builds might need to be cancelled and restarted later.

Copy link
Owner

@danmar danmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@firewave firewave merged commit 5804ef7 into danmar:main Mar 8, 2024
64 checks passed
@firewave firewave deleted the test-inject-j branch March 8, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants