Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tokenizer: removed some wrapper functions #6054

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Tokenizer: removed some wrapper functions #6054

merged 1 commit into from
Mar 5, 2024

Conversation

firewave
Copy link
Collaborator

These were used inconsistently. Also Tokenizer::list is public and used directly across the code already.

@firewave
Copy link
Collaborator Author

This might also hint that we could/should pass around the TokenList instead of the Tokenizer. Still needs to be looked at but is not important at all.

@firewave
Copy link
Collaborator Author

firewave commented Mar 5, 2024

Almost a whole week without any feedback - merging.

@firewave firewave merged commit 77406bd into danmar:main Mar 5, 2024
64 checks passed
@firewave firewave deleted the toklist2 branch March 5, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@firewave