Fix #12459 FP uninitialized variable, pointer passed to constructor #6041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfultz2
reviewed
Feb 26, 2024
| @@ -3293,7 +3293,7 @@ static ExprUsage getFunctionUsage(const Token* tok, int indirect, const Settings | |||
| } else if (ftok->str() == "{") { | |||
| return indirect == 0 ? ExprUsage::Used : ExprUsage::Inconclusive; | |||
| } else if (ftok->variable() && ftok == ftok->variable()->nameToken()) { // variable init/constructor call | |||
| if (ftok->variable()->type() && ftok->variable()->type()->needInitialization == Type::NeedInitialization::True) | |||
| if (ftok->variable()->type() && ftok->variable()->type()->classScope && ftok->variable()->type()->classScope->numConstructors == 0) | |||
There was a problem hiding this comment.
Will we still diagnose this case?
struct S {
S(char*);
int i;
};
void f() {
char c;
S s(&c);
}There was a problem hiding this comment.
No. But if we did warn, it was by accident, since there is no argument checking at all.
That line was originally added in #5713, which is about POD types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.