testrunner: stop comparing mismatching types in generic assertEquals() / added ASSERT_EQUALS_ENUM
#6035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firewave
changed the title
ASSERT_EQUALS_ENUMassertEquals() / added ASSERT_EQUALS_ENUM
firewave
force-pushed
the
assert-enum
branch
2 times, most recently
from
eea413d
to
3c27fd2
Compare
…()` / added `ASSERT_EQUALS_ENUM`
firewave
force-pushed
the
assert-enum
branch
from
e25a6a9
to
0fbe9c1
Compare
firewave
force-pushed
the
assert-enum
branch
from
64cb750
to
c94d785
Compare
firewave
commented
Feb 25, 2024
| @@ -827,8 +827,8 @@ class TestLibrary : public TestFixture { | |||
| Library library; | |||
| ASSERT(loadxmldata(library, xmldata, sizeof(xmldata))); | |||
|
|
|||
| Library::Container& A = library.containers["A"]; | |||
| Library::Container& B = library.containers["B"]; | |||
| const Library::Container& A = library.containers["A"]; | |||
There was a problem hiding this comment.
I think this false negative is already tracked in https://trac.cppcheck.net/ticket/12211.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If only one case explicitly specified the enum it would have compiled with
ASSERT_EQUALSbut we would be have an implicit conversion and would not have detected a type mismatch.