moved global CheckUnusedFunctions instance to CppCheck / cleaned up CheckUnusedFunctions interface
#6013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firewave
commented
Feb 21, 2024
| @@ -96,9 +96,9 @@ class TestUnusedFunctions : public TestFixture { | |||
|
|
|||
| // Check for unused functions.. | |||
| CheckUnusedFunctions checkUnusedFunctions; | |||
| checkUnusedFunctions.parseTokens(tokenizer, "someFile.c", settings1); | |||
There was a problem hiding this comment.
Another case of a language mismatch between tokenizing and usage.
|
Will file tickets for the |
firewave
commented
Feb 21, 2024
| @@ -560,6 +563,10 @@ unsigned int CppCheck::check(const std::string &path, const std::string &content | |||
|
|
|||
| unsigned int CppCheck::check(const FileSettings &fs) | |||
| { | |||
| // TODO: move to constructor when CppCheck no longer owns the settings | |||
There was a problem hiding this comment.
Yet another case highlighting how all the current messes I am working on are woven together...
|
This looks like a false positive: If both sides are just a |
firewave
force-pushed
the
unused-xyz-2
branch
from
8e4fab9
to
09e5d2e
Compare
|
I filed https://trac.cppcheck.net/ticket/12455 about the |
firewave
commented
Feb 21, 2024
| @@ -0,0 +1,7 @@ | |||
| static void f4_0() {} | |||
There was a problem hiding this comment.
This was a gap in the test coverage which was uncovered by me not properly propagating all the data in an earlier version of these changes.
firewave
changed the title
CheckUnusedFunctions instance to CppCheck / cleaned up CheckUnusedFunctions interfaceCheckUnusedFunctions instance to CppCheck / cleaned up CheckUnusedFunctions interface
firewave
force-pushed
the
unused-xyz-2
branch
from
09e5d2e
to
c68c0b1
Compare
…up `CheckUnusedFunctions` interface
firewave
force-pushed
the
unused-xyz-2
branch
from
c68c0b1
to
8e943c6
Compare
danmar
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.