Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some compilation errors in windows.cpp #5965

Merged
merged 5 commits into from
Feb 9, 2024

Conversation

chrchr-github
Copy link
Collaborator

@chrchr-github chrchr-github commented Feb 9, 2024

_strncpy_s_l() is apparently only available in non-unicode builds, but the other code relies on UNICODE.

@chrchr-github chrchr-github marked this pull request as draft February 9, 2024 11:13
@chrchr-github chrchr-github marked this pull request as ready for review February 9, 2024 13:38
@firewave
Copy link
Collaborator

firewave commented Feb 9, 2024

Do you still plan to address some of the compiler warnings? Otherwise I would merge it.

If you want the warnings to be errors you need to add the /WX switch.

I was thinking about adding it to runtests.sh by using the MinGW cross-compilation. That can still be done later on.

The UNICODE handling needs some reworking. No tickets about that but some stuff is sprinkled around in several PRs and branches of mine...

@chrchr-github
Copy link
Collaborator Author

The warnings are to be expected, since the test code is obviously flawed. We could try to suppress them with /w, but I don't quite see the point.

@firewave firewave merged commit 889f15e into danmar:main Feb 9, 2024
64 checks passed
@chrchr-github chrchr-github deleted the wincomp branch February 9, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants