Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coverity.yml: do not use debug STL #5962

Merged
merged 1 commit into from
Feb 9, 2024
Merged

coverity.yml: do not use debug STL #5962

merged 1 commit into from
Feb 9, 2024

Conversation

firewave
Copy link
Collaborator

@firewave firewave commented Feb 8, 2024

No description provided.

@firewave
Copy link
Collaborator Author

firewave commented Feb 8, 2024

I saw the safe_iterator being used in the Coverity traces and that is not necessary for this. Not sure if this improves anything though.

danmar
danmar approved these changes Feb 9, 2024
View reviewed changes
Copy link
Owner

@danmar danmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@firewave firewave merged commit 1a5ba4a into danmar:main Feb 9, 2024
64 checks passed
@firewave firewave deleted the cov-deb branch February 9, 2024 17:22
@firewave
Copy link
Collaborator Author

This has cleared up a lot of apparent false positives and incoherent findings within the STL only.

@firewave firewave mentioned this pull request Feb 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danmar danmar danmar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@firewave @danmar