Remove MFC defines from windows.cfg #5959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firewave
reviewed
Feb 8, 2024
| @@ -1144,17 +1144,6 @@ void GetShortPathName_validCode(const TCHAR* lpszPath) | |||
| delete[] buffer; | |||
| } | |||
|
|
|||
| class MyClass : public CObject { | |||
There was a problem hiding this comment.
This is not duplicated so it should be moved to mfc.cpp.
There was a problem hiding this comment.
... which doesn't exist, probably because mfc.cfg is just a bunch of empty defines.
There was a problem hiding this comment.
Side note: we should add a CI compilation step for windows.cpp, it totally does not compile at all.
There was a problem hiding this comment.
Side note: we should add a CI compilation step for
windows.cpp, it totally does not compile at all.
I was wondering about that...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.