Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #12413 ( False positive on Misra 10.3 for bools ) #5948

Merged
merged 3 commits into from
Feb 6, 2024
Merged

Fix #12413 ( False positive on Misra 10.3 for bools ) #5948

merged 3 commits into from
Feb 6, 2024

Conversation

0x41head
Copy link
Contributor

@0x41head 0x41head commented Feb 5, 2024

No description provided.

@0x41head 0x41head marked this pull request as ready for review February 5, 2024 17:12
@0x41head 0x41head mentioned this pull request Feb 5, 2024
Merged
@danmar
Copy link
Owner

danmar commented Feb 6, 2024

For your information the "Coverage" job is flaky.. don't worry if that fails.

danmar
danmar requested changes Feb 6, 2024
View reviewed changes
Copy link
Owner

@danmar danmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add test code in cppcheck/addons/test/misra/misra-test.c

@0x41head 0x41head requested a review from danmar February 6, 2024 07:17
danmar
danmar approved these changes Feb 6, 2024
View reviewed changes
Copy link
Owner

@danmar danmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.. in my opinion if CI is happy we can merge this

@danmar
Copy link
Owner

danmar commented Feb 6, 2024 •
edited
Loading

after we merge this... what name would you like that I add in the AUTHORS file?

@0x41head
Copy link
Contributor Author

0x41head commented Feb 6, 2024

after we merge this... what name would you like that I add in the AUTHORS file?

my username works 👍

@danmar danmar merged commit f6b538e into danmar:main Feb 6, 2024
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danmar danmar danmar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0x41head @danmar