Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated CI to Clang 19 #5945

Merged
merged 15 commits into from
Jul 30, 2024
Merged

Updated CI to Clang 19 #5945

merged 15 commits into from
Jul 30, 2024

Conversation

firewave
Copy link
Collaborator

@firewave firewave commented Feb 4, 2024

No description provided.

@firewave firewave force-pushed the clang-19 branch 2 times, most recently from 4ec0036 to 5573ae5 Compare February 12, 2024 00:56
@firewave firewave force-pushed the clang-19 branch 3 times, most recently from 8ed20dc to ecb4add Compare March 3, 2024 17:02
@firewave
Copy link
Collaborator Author

firewave commented Mar 3, 2024

I filed llvm/llvm-project#83732 about the modernize-use-designated-initializers false positives.

@firewave firewave force-pushed the clang-19 branch 2 times, most recently from 11485cc to afc4877 Compare March 4, 2024 00:23
@firewave firewave force-pushed the clang-19 branch 2 times, most recently from 1c1758c to 528a32b Compare April 7, 2024 17:32
@firewave firewave force-pushed the clang-19 branch 2 times, most recently from 9618787 to 3cb41b9 Compare June 12, 2024 08:48
@firewave
Copy link
Collaborator Author

firewave commented Jul 11, 2024 •
edited
Loading

This needs tickets filed about the performance-unnecessary-copy-initialization case which are not detected by us.

@firewave
Copy link
Collaborator Author

firewave commented Jul 11, 2024 •
edited
Loading

CheckOther::constVariableError() - https://trac.cppcheck.net/ticket/12925
ProjectFileDialog::loadFromProjectFile() - https://trac.cppcheck.net/ticket/12926 / https://trac.cppcheck.net/ticket/12934
The one in isTemporary() looks like a variation on this.

chrchr-github
chrchr-github reviewed Jul 11, 2024
View reviewed changes
gui/mainwindow.cpp Outdated Show resolved Hide resolved
@firewave
Copy link
Collaborator Author

Clang 19 release candidate has been released and the apt mirror should also have made the branch switch. As we only utilize the binaries in the CI we can merge this now.

@firewave
Copy link
Collaborator Author

I filed llvm/llvm-project#101181 upstream about the performance-unnecessary-value-param false positive.

@firewave firewave marked this pull request as ready for review July 30, 2024 13:20
@chrchr-github chrchr-github merged commit 02e2230 into danmar:main Jul 30, 2024
63 checks passed
@firewave firewave deleted the clang-19 branch July 30, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrchr-github chrchr-github chrchr-github left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@firewave @chrchr-github