fixed many COPY_INSTEAD_OF_MOVE Coverity warnings
#5944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firewave
commented
Feb 4, 2024
cli/cppcheckexecutor.cpp
Outdated
| @@ -194,7 +194,7 @@ int CppCheckExecutor::check(int argc, const char* const argv[]) | |||
| mStdLogger = new StdLogger(settings); | |||
|
|
|||
| CppCheck cppCheck(*mStdLogger, true, executeCommand); | |||
| cppCheck.settings() = settings; | |||
| cppCheck.settings() = std::move(settings); | |||
There was a problem hiding this comment.
This is a bogus warning. The object is referenced in StdLogger.
There was a problem hiding this comment.
The Settings object should also be const after construction to make sure it is no longer modified afterwards. That is still WIP.
Also the copy will go away after #4964 is done.
There was a problem hiding this comment.
This is a variant of https://trac.cppcheck.net/ticket/12364.
firewave
force-pushed
the
coverity-move
branch
from
949bfe2
to
d307417
Compare
|
The |
firewave
force-pushed
the
coverity-move
branch
from
3732603
to
c636b73
Compare
danmar
approved these changes
Feb 5, 2024
I gave it a short spin in the profiler and it doesn't have much of an impact. Guess the most important were already found earlier by review and profiling. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.