Fix #12389 (GUI: premiumaddon is not executed properly anymore) #5923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danmar
force-pushed
the
fix-12389
branch
2 times, most recently
from
a0f9972
to
f10f746
Compare
|
I will finish this when PR 5921 has been merged. |
danmar
commented
Feb 1, 2024
gui/mainwindow.cpp
Outdated
| @@ -486,6 +486,11 @@ void MainWindow::saveSettings() const | |||
|
|
|||
| void MainWindow::doAnalyzeProject(ImportProject p, const bool checkLibrary, const bool checkConfiguration) | |||
| { | |||
| QSharedPointer<Settings> checkSettingsPtr = getCppcheckSettings(); | |||
There was a problem hiding this comment.
For information; I moved this getCppcheckSettings call up because if there is a failure and we want to abort it is better that we abort early before clearResults and other stuff..
danmar
added a commit
that referenced
this pull request
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.