Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI-unixish-docker.yml: fixate hendrikmuhs/ccache-action on 1.2.11 to fix older images #5918

Merged
merged 1 commit into from
Jan 28, 2024
Merged

CI-unixish-docker.yml: fixate hendrikmuhs/ccache-action on 1.2.11 to fix older images #5918

merged 1 commit into from
Jan 28, 2024

Conversation

firewave
Copy link
Collaborator

@firewave firewave commented Jan 27, 2024 •
edited
Loading

@firewave firewave mentioned this pull request Jan 27, 2024
Open
@firewave firewave mentioned this pull request Jan 27, 2024
Merged
@firewave firewave marked this pull request as ready for review January 27, 2024 23:49
@firewave
Copy link
Collaborator Author

The newer hendrikmuhs/ccache-action step also seems to cause a major slowdown in the Post ccache step: hendrikmuhs/ccache-action#178 (comment).

danmar
danmar approved these changes Jan 28, 2024
View reviewed changes
Copy link
Owner

@danmar danmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking at this!!

Looks good to me.

@firewave firewave merged commit cecbe18 into danmar:main Jan 28, 2024
64 checks passed
@firewave firewave deleted the ccache-x branch January 28, 2024 18:04
@firewave
Copy link
Collaborator Author

The newer hendrikmuhs/ccache-action step also seems to cause a major slowdown in the Post ccache step

I filed a separate ticket about this: hendrikmuhs/ccache-action#181. A fix has already been proposed.

danmar pushed a commit that referenced this pull request Feb 3, 2024
@firewave @danmar
CI-unixish-docker.yml: fixate hendrikmuhs/ccache-action on 1.2.11…
3369699 
… to fix older images (#5918)

See

https://github.com/danmar/cppcheck/actions/runs/7677304162/job/20926809147?pr=5917
hendrikmuhs/ccache-action#178
danmar pushed a commit that referenced this pull request Feb 3, 2024
@firewave @danmar
CI-unixish-docker.yml: fixate hendrikmuhs/ccache-action on 1.2.11…
c22b928 
… to fix older images (#5918)

See

https://github.com/danmar/cppcheck/actions/runs/7677304162/job/20926809147?pr=5917
hendrikmuhs/ccache-action#178
danmar pushed a commit that referenced this pull request Feb 3, 2024
@firewave @danmar
CI-unixish-docker.yml: fixate hendrikmuhs/ccache-action on 1.2.11…
79b380e 
… to fix older images (#5918)

See

https://github.com/danmar/cppcheck/actions/runs/7677304162/job/20926809147?pr=5917
hendrikmuhs/ccache-action#178
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danmar danmar danmar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@firewave @danmar