testrunner: reduced usage of mutable Settings / some cleanups
#5909
Conversation
firewave
force-pushed
the
symdb-2
branch
2 times, most recently
from
85c54f4
to
1287363
Compare
| @@ -731,15 +733,15 @@ class TestClass : public TestFixture { | |||
| // Clear the error log | |||
| errout.str(""); | |||
|
|
|||
| Preprocessor preprocessor(settings0); | |||
There was a problem hiding this comment.
This was relying on the modifications checkVirtualDestructor() did.
| @@ -8199,10 +8195,9 @@ class TestOther : public TestFixture { | |||
| } | |||
|
|
|||
| { | |||
| Settings s = settingsBuilder().checkUnusedTemplates().build(); | |||
There was a problem hiding this comment.
Unnecessary as checkUnusedTemplates is true by default.
There was a problem hiding this comment.
This now uses _settings which has std.cfg loaded but I do think this is not an issue.
| @@ -11093,13 +11088,11 @@ class TestOther : public TestFixture { | |||
| } | |||
|
|
|||
| void forwardAndUsed() { | |||
| Settings s = settingsBuilder().checkUnusedTemplates().build(); | |||
There was a problem hiding this comment.
Unnecessary as checkUnusedTemplates is true by default.
There was a problem hiding this comment.
This now uses _settings which has std.cfg loaded but I do think this is not an issue.
| @@ -633,8 +633,6 @@ class TestValueFlow : public TestFixture { | |||
| const char *code; | |||
| std::vector<std::string> lifetimes; | |||
|
|
|||
| LOAD_LIB_2(settings.library, "std.cfg"); | |||
There was a problem hiding this comment.
Unnecessary as std.cfg is already loaded in settings.
| @@ -1012,7 +1010,6 @@ class TestValueFlow : public TestFixture { | |||
|
|
|||
| // ~ | |||
| code = "x = ~0U;"; | |||
| PLATFORM(settings.platform, Platform::Type::Native); // ensure platform is native | |||
There was a problem hiding this comment.
Obsolete as we now default to Native on all platforms.
| @@ -6013,8 +6010,6 @@ class TestValueFlow : public TestFixture { | |||
| void valueFlowContainerSize() { | |||
| const char *code; | |||
|
|
|||
| LOAD_LIB_2(settings.library, "std.cfg"); | |||
There was a problem hiding this comment.
Unnecessary as std.cfg is already loaded in settings.
| @@ -6799,8 +6794,6 @@ class TestValueFlow : public TestFixture { | |||
| { | |||
| const char* code; | |||
|
|
|||
| LOAD_LIB_2(settings.library, "std.cfg"); | |||
There was a problem hiding this comment.
Unnecessary as std.cfg is already loaded in settings.
| @@ -6826,9 +6819,8 @@ class TestValueFlow : public TestFixture { | |||
| void valueFlowDynamicBufferSize() { | |||
| const char *code; | |||
|
|
|||
| LOAD_LIB_2(settings.library, "std.cfg"); | |||
There was a problem hiding this comment.
Unnecessary as std.cfg is already loaded in settings.
No description provided.