Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CppCheck: no need to preprocess markup files as they are not actual source code #5896

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

firewave
Copy link
Collaborator

It should not be necessary to preprocess markup files. We only need to tokenize them so function calls can be marked as used.

@firewave
Copy link
Collaborator Author

This is one of the cases which is blocking #5853 because we were not able to determine/force a language for the input.

@firewave firewave marked this pull request as draft January 19, 2024 09:38
@firewave firewave marked this pull request as ready for review January 19, 2024 09:38
@danmar
Copy link
Owner

danmar commented Jan 19, 2024

Is it "just redundant"? .. no way to test it?

btw I have been told that handling of QML was broken.. I dont have access to the code that does not work but I fear the testing is not very good.

@firewave
Copy link
Collaborator Author

Is it "just redundant"? .. no way to test it?

btw I have been told that handling of QML was broken.. I dont have access to the code that does not work but I fear the testing is not very good.

This is tested by test/cli/qml_test.py.

@firewave
Copy link
Collaborator Author

btw I have been told that handling of QML was broken.. I dont have access to the code that does not work but I fear the testing is not very good.

Possibly a more complex one than we use in our tests. I thought about looking at some random .qml files from the web but I have too much on my plate as is.

@danmar
Copy link
Owner

danmar commented Jan 19, 2024

I thought about looking at some random .qml files from the web but I have too much on my plate as is.

good idea! hmm.. we have lots of stuff to do during Q1 but maybe I can delegate this in Q2..

@firewave firewave merged commit d0a02bb into danmar:main Jan 19, 2024
64 checks passed
@firewave firewave deleted the markup-short branch January 19, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants