Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

properly reset CheckUnusedFunctions data in tests / made CheckUnusedFunctions::clear() private #5892

Merged
merged 1 commit into from
Jan 18, 2024
Merged

properly reset CheckUnusedFunctions data in tests / made CheckUnusedFunctions::clear() private #5892

merged 1 commit into from
Jan 18, 2024

Conversation

firewave
Copy link
Collaborator

This was exposed by running TestSuppressions::suppressingSyntaxErrorAndExitCodeFiles and TestSuppressions::suppressingSyntaxErrorAndExitCodeMultiFileFiles on their own.

@firewave
Copy link
Collaborator Author

This might explain issues I was having adding some asserts as well as getting #5647 to work. It also happened in #5884.

@firewave
Copy link
Collaborator Author

This also suggests that unusedFunction is not (and never has been) working properly at all in the GUI. I have not looked into it yet. Even more reason to finally get CheckUnusedFunctions right.

@firewave firewave mentioned this pull request Jan 18, 2024
Merged
@firewave
Copy link
Collaborator Author

This was exposed by running TestSuppressions::suppressingSyntaxErrorAndExitCodeFiles and TestSuppressions::suppressingSyntaxErrorAndExitCodeMultiFileFiles on their own.

I have code in a branch which does this automatically. Will clean it up and prepare a PR.

danmar
danmar approved these changes Jan 18, 2024
View reviewed changes
Copy link
Owner

@danmar danmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@firewave firewave merged commit cae6719 into danmar:main Jan 18, 2024
64 checks passed
@firewave firewave deleted the unused-reset branch January 18, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danmar danmar danmar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@firewave @danmar