Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #12288 FP: uninitvar (in place new) #5859

Merged
merged 3 commits into from
Jan 12, 2024
Merged

Fix #12288 FP: uninitvar (in place new) #5859

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3fb06e3
Fix #12288 FP: uninitvar (in place new)
chrchr-github Jan 7, 2024
e0a1eba
Fix
chrchr-github Jan 7, 2024
e13f2fc
indirect
chrchr-github Jan 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/astutils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2416,6 +2416,9 @@ bool isVariableChangedByFunctionCall(const Token *tok, int indirect, const Setti
if (deref && indirect > 0)
indirect--;

if (indirect == 1 && tok->isCpp() && tok->tokAt(-1) && Token::simpleMatch(tok->tokAt(-2), "new (")) // placement new TODO: fix AST
return true;

int argnr;
tok = getTokenArgumentFunction(tok, argnr);
if (!tok)
Expand Down
6 changes: 6 additions & 0 deletions test/testuninitvar.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6373,6 +6373,12 @@ class TestUninitVar : public TestFixture {
" g(buf);\n"
"}\n");
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: buf\n", errout.str());

valueFlowUninit("void f() {\n" // #12288
" char buf[100];\n"
" char* p = new (buf) char[100];\n"
"}\n");
ASSERT_EQUALS("", errout.str());
}

void valueFlowUninitBreak() { // Do not show duplicate warnings about the same uninitialized value
Expand Down
Loading