AddonInfo: const-ified loading and improved errorhandling #5834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tried to simply this by using some helper countless times but I wasn't satisfied with the resulting code (I also had to re-do it completely as I could no longer find any of my stashed previous attempts ...). Maybe something will come to me after I const-ified the other loading code as well. CC @thingsconnected |
danmar
reviewed
Jan 5, 2024
danmar
approved these changes
Jan 5, 2024
| if (!val.is<std::string>()) | ||
| return "Loading " + fileName + " failed. 'executable' must be a string."; | ||
| addoninfo.executable = getFullPath(val.get<std::string>(), fileName); | ||
| return ""; // TODO: why bail out? |
There was a problem hiding this comment.
reason: It does not make much sense to configure both "executable" and "script".. If "executable" is provided then current intention is to just ignore the "script" if it's there. We could add a warning/error..
There was a problem hiding this comment.
Thanks. I see - well, no ... I don't. Will take a look later. Will also check if there is proper/actual documentation for the format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.