modernized and cleaned up CMake files / explicitly check for CMake 3.13 with Visual Studio #5825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firewave
commented
Jan 4, 2024
| project(Cppcheck) | ||
| cmake_minimum_required(VERSION 3.5) | ||
| if (MSVC) | ||
| cmake_minimum_required(VERSION 3.13) |
There was a problem hiding this comment.
subsequent calls to raise the required version are allowed
firewave
commented
Jan 4, 2024
| @@ -72,6 +72,10 @@ else() | |||
| set(CMAKE_DISABLE_PRECOMPILE_HEADERS On CACHE BOOL "Disable precompiled headers") | |||
| endif() | |||
|
|
|||
| if (CMAKE_VERSION VERSION_LESS "3.9") | |||
| message(FATAL_ERROR "Registering tests with CTest requires at least CMake 3.9. Use REGISTER_TESTS=OFF to disable this.") | |||
There was a problem hiding this comment.
This would have bailed out in the test code later on before. I moved it up so there is not a stray cmake_minimum_required() call somewhere in the code.
firewave
commented
Jan 4, 2024
|
|
||
| set(CMAKE_EXPORT_COMPILE_COMMANDS ON) | ||
|
|
||
| include(GNUInstallDirs) | ||
|
|
||
| include(cmake/ccache.cmake) |
There was a problem hiding this comment.
No longer necessary. Was a work around for CMake 2.8.
firewave
commented
Jan 4, 2024
|
|
||
| include(cmake/cxx11.cmake) | ||
| use_cxx11() | ||
| set (CMAKE_CXX_STANDARD_REQUIRED ON) |
There was a problem hiding this comment.
moved from cxx11.cmake as it is generic and available now.
|
Requires #5398 to be merged first. |
…13 with Visual Studio
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.