Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set main version to 2.13.99 #5818

Merged
merged 5 commits into from
Jan 4, 2024
Merged

Set main version to 2.13.99 #5818

merged 5 commits into from
Jan 4, 2024

Conversation

chrchr-github
Copy link
Collaborator

No description provided.

@danmar
Copy link
Owner

danmar commented Jan 3, 2024

hmm .. there are more versions to change. See c23521a

@danmar
Copy link
Owner

danmar commented Jan 3, 2024

btw there is a strange CPPCHECK_DEVMINOR_VERSION handling in version.h it would be good to tweak this handling.

@chrchr-github
Copy link
Collaborator Author

hmm .. there are more versions to change. See c23521a

Can't we merge that commit into main then?

@danmar
Copy link
Owner

danmar commented Jan 3, 2024

Can't we merge that commit into main then?

That does not help you have to also tweak all the versions from release-version to debug-version then..

@danmar
Copy link
Owner

danmar commented Jan 3, 2024

I would suggest that we rename CPPCHECK_DEVMINOR_VERSION to CPPCHECK_BUGFIX_VERSION. It can always be "99" for dev builds. When I make a release branch I think it would make sense that I increment the MINOR_VERSION and zero the BUGFIX_VERSION.

@chrchr-github chrchr-github changed the title Update productInfo.wxi Set main version to 2.13.99 Jan 3, 2024
lib/version.h Outdated Show resolved Hide resolved
lib/version.h Show resolved Hide resolved
Copy link
Owner

@danmar danmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chrchr-github chrchr-github merged commit efa8a08 into main Jan 4, 2024
68 checks passed
@chrchr-github chrchr-github deleted the chrchr-github-patch-1 branch January 4, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants