Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addons/namingng.py: Fix self-reference naming.py. #5795

Closed
wants to merge 1 commit into from

Conversation

mvds00
Copy link
Contributor

@mvds00 mvds00 commented Dec 22, 2023

namingng.py refers to itself by the name naming.py. This is confusing, especially as a different plugin by the name naming.py exists, and the string "naming.py" is output for each and every issue found by namingng.py.

The self-references are changed to namingng.py.

namingng.py refers to itself by the name naming.py. This is confusing,
especially as a *different* plugin by the name naming.py exists, and the string
"naming.py" is output for each and every issue found by namingng.py.

The self-references are changed to namingng.py.
@mvds00
Copy link
Contributor Author

mvds00 commented Dec 23, 2023

Note that this PR becomes obsolete if #5793 were to be accepted.

@danmar
Copy link
Owner

danmar commented Dec 23, 2023

Note that this PR becomes obsolete if #5793 were to be accepted.

I guess #5793 can be accepted after some tweak

@mvds00 mvds00 closed this Dec 25, 2023
@mvds00 mvds00 deleted the pullreq2 branch December 25, 2023 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants