fix casing in variable name

[EricSesterhennX41]

The attribute movedValue is misspelled with an uppercase V, this leads to errors when printing token values:

$ python3 runaddon.py test.py test.c.dump 
Checking test.c.dump...
Checking test.c.dump, config ...
line 2 str=""lala\n""
Traceback (most recent call last):
  File "/home/eric/tools/cppcheck/addons/runaddon.py", line 11, in <module>
    cppcheck.runcheckers()
  File "/home/eric/tools/cppcheck/addons/cppcheck.py", line 39, in runcheckers
    c(cfg, data)
  File "test.py", line 9, in func
    print(f'    {value}')
  File "/home/eric/tools/cppcheck/addons/cppcheckdata.py", line 907, in __repr__
    ", ".join(("{}={}".format(a, repr(getattr(self, a))) for a in attrs))
  File "/home/eric/tools/cppcheck/addons/cppcheckdata.py", line 907, in <genexpr>
    ", ".join(("{}={}".format(a, repr(getattr(self, a))) for a in attrs))
AttributeError: 'Value' object has no attribute 'movedValue'

[firewave]

I would have liked to have a unit test for this fix.

[EricSesterhennX41]

On 12/18/23 19:23, Oliver Stöneberg wrote: I would have liked to have a unit test for this fix.

Do you have a pointer where that should be placed? I see `addons/test` for tests regarding the python written addons, but no place with tests for `cppcheckdata.py`. Am I missing something?

…

-- Eric Sesterhenn (Principal Security Consultant) X41 D-SEC GmbH, Krefelder Str. 123, 52070 Aachen T: +49 241 9809418-0, Fax: -9 Unternehmenssitz: Aachen, Amtsgericht Aachen: HRB19989 Geschäftsführer: Markus Vervier

[danmar]

@firewave
hmm I thought so too at first but firstly the doxygen comment fix can't be unit tested.

the other fix is not very testable neither. The code is used in two cases for debugging:

• if you run a python debugger and in the debugger write : print(value)
• if you put a temporary print(value) in the addon code for debugging purposes

I assumed it will have no runtime impact for our users.

[danmar]

@EricSesterhennX41 we don't have a specific cppcheckdata.py test as far as I know. Feel free to create it.

[EricSesterhennX41]

I created #5782 but get some errors regarding PIP that I do not know how to deal with.

…

-- Eric Sesterhenn (Principal Security Consultant) X41 D-SEC GmbH, Krefelder Str. 123, 52070 Aachen T: +49 241 9809418-0, Fax: -9 Unternehmenssitz: Aachen, Amtsgericht Aachen: HRB19989 Geschäftsführer: Markus Vervier