Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #12131: No warning for missing override specifier for virtual function with different default argument #5763

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

olabetskyi
Copy link
Collaborator

added check for the end off both functions parameter lists during compare

Copy link
Owner

@danmar danmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. As you change Function::argsMatch, I suggest that you run test-my-pr.py to ensure that it works:

cd cppcheck
git checkout ticket_12131
make clean
python3 tools/test-my-pr.py

Leave the script running for half a day or so.

I think the results is saved in ~/cppcheck-test-my-pr-workfolder/my_check_diff.log and those would be interesting to see.

This could affect many checkers so you might see various warnings.

@danmar danmar added the merge-after-next-release Wait with merging this PR until after the next Release label Dec 15, 2023
@chrchr-github chrchr-github merged commit 88e4f2e into danmar:main Jan 24, 2024
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-after-next-release Wait with merging this PR until after the next Release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants