Fixed #12260 (false positive: unusedVariable with side effects in member initialization) #5762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olabetskyi
changed the title
firewave
reviewed
Dec 14, 2023
| "int main() {\n" | ||
| " A a;\n" | ||
| "}"); | ||
| TODO_ASSERT_EQUALS("error", "", errout.str()); |
There was a problem hiding this comment.
The assert looks wrong. Looks like a copy and paste error from the one above - and that also looks fishy.
There was a problem hiding this comment.
Let me check it. Thank you
There was a problem hiding this comment.
The one above is actually ok as a TODO, since that constructor has no side effects (class F).
There was a problem hiding this comment.
The one above is actually ok as a TODO, since that constructor has no side effects (
class F).
"fishy" in the sense that the expected message is just bogus. I did not look at the contents of it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
revert old changes