Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testrunner: do not suppress duplicated error messages #5736

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

firewave
Copy link
Collaborator

@firewave firewave commented Dec 7, 2023

No description provided.

@firewave
Copy link
Collaborator Author

firewave commented Dec 7, 2023

Having a fourth(!) place which will filter out duplicated messages makes things harder to test #5280 aside from just being insane.

I always thought we need this to prevent duplicated messages from headers but not from actual checks.

@firewave firewave force-pushed the no-duplicate branch 2 times, most recently from 9db2aff to 87ba67b Compare December 8, 2023 17:05
@firewave firewave marked this pull request as ready for review December 8, 2023 17:35
@firewave firewave merged commit 87540e6 into danmar:main Jan 4, 2024
68 checks passed
@firewave firewave deleted the no-duplicate branch January 4, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants