Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid const_cast usage in headers #5720

Merged
merged 3 commits into from
Dec 6, 2023
Merged

avoid const_cast usage in headers #5720

merged 3 commits into from
Dec 6, 2023

Conversation

firewave
Copy link
Collaborator

@firewave firewave commented Dec 2, 2023

No description provided.

@firewave
Copy link
Collaborator Author

firewave commented Dec 2, 2023

This mainly supersedes #4344 except for the SymbolDatabase changes which are not that straight forward.

@firewave firewave mentioned this pull request Dec 2, 2023
Merged
@firewave firewave changed the title avoid some const_cast usage in header avoid some const_cast usage in headers Dec 2, 2023
@firewave
Copy link
Collaborator Author

firewave commented Dec 2, 2023

SymbolDatbase now also included. I made a mistake on my first attempt.

@firewave firewave changed the title avoid some const_cast usage in headers avoid const_cast usage in headers Dec 2, 2023
@firewave firewave marked this pull request as ready for review December 2, 2023 15:29
@firewave firewave merged commit 5761e55 into danmar:main Dec 6, 2023
68 checks passed
@firewave firewave deleted the const_cast-3 branch December 6, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danmar danmar danmar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@firewave @danmar