CmdLineParser: return enum from parseFromArgs() instead of using additional member
#5698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requires #5676 to be merged first. |
firewave
commented
Nov 24, 2023
| @@ -104,6 +104,19 @@ class TestCmdlineParser : public TestFixture { | |||
| // TODO: verify that the redirect output is empty | |||
| } | |||
|
|
|||
| // add specialization so the enums can be compared without a cast | |||
| template<typename T, typename U> | |||
There was a problem hiding this comment.
I had to add the general version because I cannot create a specialization for the template in the parent class.
firewave
commented
Nov 24, 2023
test/testcmdlineparser.cpp
Outdated
| } | ||
|
|
||
| template<> | ||
| bool assertEquals<CmdLineParser::Result, CmdLineParser::Result>(const char* const filename, const unsigned int linenr, const CmdLineParser::Result& expected, const CmdLineParser::Result& actual) const |
There was a problem hiding this comment.
I added the specialization so I didn't have to introduce hundreds of static_cast into the asserts.
There was a problem hiding this comment.
If we find a way to simply this specialization we can clean up other tests.
firewave
force-pushed
the
cmd-ret
branch
2 times, most recently
from
866868a
to
2b48af7
Compare
danmar
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.