CppCheckExecutor: do not modify settings after they were passed to CppCheck
#5697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firewave
commented
Nov 23, 2023
| @@ -230,9 +233,10 @@ bool CppCheckExecutor::reportSuppressions(const Settings &settings, bool unusedF | |||
| /* | |||
| * That is a method which gets called from check_wrapper | |||
| * */ | |||
| int CppCheckExecutor::check_internal(CppCheck& cppcheck) | |||
| int CppCheckExecutor::check_internal(CppCheck& cppcheck) const | |||
There was a problem hiding this comment.
We did not detect this since the function body contains preprocessor usage.
firewave
commented
Nov 23, 2023
| @@ -183,10 +183,13 @@ int CppCheckExecutor::check(int argc, const char* const argv[]) | |||
| return EXIT_SUCCESS; | |||
| } | |||
|
|
|||
| settings.loadSummaries(); | |||
There was a problem hiding this comment.
No need to check settings.buildDir before calling this since it will do that by itself.
|
This is a change towards #4964 as well as making the settings immutable after they have been created. |
danmar
approved these changes
Nov 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.