Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compilerDefinitions.cmake: fixed faulty add_compile_definitions() value for MSVC #5690

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

firewave
Copy link
Collaborator

also fixes <command line>(7,9): error : macro name must be an identifier with clang-cl allowing the build to complete

…alue

also fixes `<command line>(7,9): error : macro name must be an identifier` with `clang-cl` allowing the build to complete
@firewave
Copy link
Collaborator Author

firewave commented Nov 21, 2023

clang-cl is not yet usable. I have some build improvements sitting in a branch since quite a while which I will submit soon.

@firewave firewave changed the title compilerDefinitions.cmake: fixed faulty add_compile_definitions() value compilerDefinitions.cmake: fixed faulty add_compile_definitions() value for MSVC Nov 21, 2023
@chrchr-github chrchr-github merged commit 693702d into danmar:main Nov 22, 2023
68 checks passed
@firewave firewave deleted the cmake-vs branch November 22, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants