Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enabled some clang-tidy warnings for non-GUI code #5679

Merged
merged 3 commits into from
Nov 20, 2023

Conversation

firewave
Copy link
Collaborator

@firewave firewave commented Nov 19, 2023

There are some clang-tidy warnings which cannot properly handle the extensions used in the Qt code so the produce lots of false positives and were previously enabled. With clang-tidy now offering the possibility to inherit the parent configuration we can enable these across the project and simply disable them for the GUI code.

No additional warnings were found as they were already fixed in earlier commits without enabling the checks in question.

@firewave
Copy link
Collaborator Author

The checks also seem quite light:

   ---User Time---   --System Time--   --User+System--   ---Wall Time---  --- Name ---
[...]
   0.0166 (  0.4%)   0.0303 (  0.4%)   0.0469 (  0.4%)   0.0473 (  0.4%)  readability-convert-member-functions-to-static
[...]
   0.0109 (  0.2%)   0.0252 (  0.3%)   0.0360 (  0.3%)   0.0360 (  0.3%)  readability-redundant-access-specifiers

@firewave firewave marked this pull request as ready for review November 19, 2023 21:49
@chrchr-github chrchr-github merged commit 3bafe16 into danmar:main Nov 20, 2023
68 checks passed
@firewave firewave deleted the tidy-qt branch November 20, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants