Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed #12059 - added --fsigned-char and --funsigned-char command-line options #5580

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

firewave
Copy link
Collaborator

No description provided.

@firewave firewave force-pushed the unsigned-char branch 2 times, most recently from 2bce22c to b69539a Compare October 26, 2023 09:13
@danmar
Copy link
Owner

danmar commented Nov 4, 2023

why not just create a platform file instead? we get multiple options to perform the same task.

@firewave
Copy link
Collaborator Author

firewave commented Nov 4, 2023

why not just create a platform file instead? we get multiple options to perform the same task.

Because it can be controlled via a compiler flag. The platform would only reflect the default (which we are not doing properly yet) and if you want to change that you have to create a temporary copy of the platform file and adjust that value which is very inconvenient.

This is in preparation of #4960.

Also it being a compiler flag that could actually modified for each file separately. So that should not be part of the platform at all but needs to be handled completely different. How much sense that would make is questionable to me.

@danmar
Copy link
Owner

danmar commented Nov 6, 2023

It still feels redundant but well supporting some gcc flags does make sense to me..

Also it being a compiler flag that could actually modified for each file separately. So that should not be part of the platform at all but needs to be handled completely different. How much sense that would make is questionable to me.

Yeah why would people do that? :-)

cli/cmdlineparser.cpp Outdated Show resolved Hide resolved
@firewave
Copy link
Collaborator Author

firewave commented Nov 6, 2023

Yeah why would people do that? :-)

Thinking about it. In case of projects files which might contains various different resulting binaries that might be valid though.

@firewave
Copy link
Collaborator Author

firewave commented Nov 6, 2023

See https://trac.cppcheck.net/ticket/12089 also. I need to elaborate more in the ticket though.

@danmar danmar merged commit 2a15428 into danmar:main Nov 8, 2023
65 checks passed
@firewave firewave deleted the unsigned-char branch November 8, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants